Fix/sanitize-endpoints-tag-during-parsing#328
Merged
emann merged 3 commits intoopenapi-generators:mainfrom Feb 12, 2021
Merged
Conversation
e87cd13 to
d14f579
Compare
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 1395 1394 -1
=========================================
- Hits 1395 1394 -1
Continue to review full report at Codecov.
|
emann
suggested changes
Feb 8, 2021
Contributor
emann
left a comment
There was a problem hiding this comment.
Thanks for the PR @p1-ra! Just a small change to the changelog.
Also just double checking - did you run task re to check if there are any changes to the golden master? I don't think there would be so you may have already done so, just want to be sure :)
Collaborator
|
@emann the e2e tests in CI would have failed if it needed a |
Co-authored-by: Ethan Mann <emannguitar@gmail.com>
bd49582 to
86fa00d
Compare
Contributor
Author
|
I've updated the changelog and rebased the branch on top of |
emann
approved these changes
Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix/sanitize-endpoints-tag-during-parsing
Description
During the parsing of a Document that have two endpoints respectively tagged with
AMF Subscription Info (Document)andAmfSubscriptionInfo (Document). They are considered as two different endpoints by the parser. Later on during the building of the API these tags are sanitized and transformed to snake case and are considered to belonging to the same endpoint (expected behaviour imo).It's lead to an error during the creation of the directory for it since the same directory is tried to be created twice.
This PR will move the sanitize behaviour of the tag into parser. These two tags are now considered to belonging to the same endpoint tagged
amf_subscription_info_document.QA Notes & Product impact
Sanitize endpoints tag during parsing (transform them to snake case), thus two endpoint tagged with respectivily
AMF Subscription Info (Document)andAmfSubscriptionInfo (Document)will be considered to belongs to the same endpoint taggedamf_subscription_info_document@dbanty