BUG: If a float-specified field holds an integer number, the resultin…#1421
Open
wolfgang-noichl wants to merge 1 commit intoopenapi-generators:mainfrom
Open
BUG: If a float-specified field holds an integer number, the resultin…#1421wolfgang-noichl wants to merge 1 commit intoopenapi-generators:mainfrom
wolfgang-noichl wants to merge 1 commit intoopenapi-generators:mainfrom
Conversation
…g object is int instead of float
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g object is int instead of float.
If a float field is specified, and the float is e.g. 5.0, representing it as "5" is valid json (because it does not destinguish between "integer" floats and ints). Right now, this results in an
intobject in python, even though this violates the schema.This is kind of a quick-and-dirty patch to the issue, but it does solve the problem at hand.
Ideas how to solve the problem in a cleaner way are much appreciated :)