fix: Handle octet-stream content media type as binary format#1418
Open
gudjonragnar wants to merge 1 commit intoopenapi-generators:mainfrom
Open
fix: Handle octet-stream content media type as binary format#1418gudjonragnar wants to merge 1 commit intoopenapi-generators:mainfrom
gudjonragnar wants to merge 1 commit intoopenapi-generators:mainfrom
Conversation
Author
|
Not sure if this is the correct implementation since I am not very familiar with the code base, so very much open to changing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fastapi fixed their spec generator to output
contentMediaType: application/octet-streaminstead offormat: binary.This results in a changed behaviour for the generated client when it comes to file uploads going from taking a File object to taking a string.
This patch should fix that.