Skip to content

Small Improvement in the async chat response code. - #959

Merged
rattrayalex merged 14 commits into
openai:nextfrom
ssojoodi:improvement/update-async-response-streaming-example
Dec 9, 2023
Merged

Small Improvement in the async chat response code.#959
rattrayalex merged 14 commits into
openai:nextfrom
ssojoodi:improvement/update-async-response-streaming-example

Conversation

@ssojoodi

@ssojoodi ssojoodi commented Dec 8, 2023

Copy link
Copy Markdown
Contributor
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Improvement to the README file, specifically the Streaming Responses example. This example runs as is now (circa Python 3.10).

Additional context & links

@ssojoodi
ssojoodi requested a review from a team as a code owner December 8, 2023 23:17
@rattrayalex

Copy link
Copy Markdown
Contributor

Thank you for the contribution!

@rattrayalex
rattrayalex changed the base branch from main to next December 9, 2023 00:03
@rattrayalex

Copy link
Copy Markdown
Contributor

@ssojoodi there's a merge conflict because we recently fixed the prompt -> model thing, could you update accordingly?

@ssojoodi

ssojoodi commented Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

@rattrayalex done. Please have a look. Thanks.

@rattrayalex rattrayalex reopened this Dec 9, 2023
@rattrayalex
rattrayalex merged commit fb9d0a3 into openai:next Dec 9, 2023
@rattrayalex

Copy link
Copy Markdown
Contributor

Thank you!

@ssojoodi
ssojoodi deleted the improvement/update-async-response-streaming-example branch December 9, 2023 22:51
@stainless-bot stainless-bot mentioned this pull request Dec 11, 2023
megamanics pushed a commit to devops-testbed/openai-python that referenced this pull request Aug 14, 2024
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants