feat(config): wire id_generator from declarative configuration to TracerProvider#5363
Open
aman-panjwani wants to merge 6 commits into
Open
feat(config): wire id_generator from declarative configuration to TracerProvider#5363aman-panjwani wants to merge 6 commits into
aman-panjwani wants to merge 6 commits into
Conversation
rads-1996
reviewed
Jun 30, 2026
| ) | ||
| id_generator = ( | ||
| _create_id_generator(config.id_generator) | ||
| if config is not None and config.id_generator is not None |
Contributor
There was a problem hiding this comment.
should we check using hasattr, to see if id_generator exists on config or not?
Contributor
Author
There was a problem hiding this comment.
Yeah! Added hasattr check to guard against configs that don't have the id_generator
MikeGoldsmith
approved these changes
Jul 1, 2026
MikeGoldsmith
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks @aman-panjwani. I've left a couple of small suggestions 👍🏻
| @@ -0,0 +1 @@ | |||
| `opentelemetry-sdk`: wire id_generator from declarative configuration to TracerProvider | |||
Member
There was a problem hiding this comment.
The filename should be 5363.added, as this is a new feature.
Comment on lines
+365
to
+366
| name = next(iter(config.additional_properties)) | ||
| return load_entry_point("opentelemetry_id_generator", name)() |
Member
There was a problem hiding this comment.
We should pass in kwargs here so any additional_properties from the config are passed in.
Suggested change
| name = next(iter(config.additional_properties)) | |
| return load_entry_point("opentelemetry_id_generator", name)() | |
| name, plugin_config = next(iter(config.additional_properties.items())) | |
| return load_entry_point("opentelemetry_id_generator", name)(**(plugin_config or {})) |
dab14fa to
4dc7a06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wires the
id_generatorfield from declarative configuration toTracerProvider, closing the parity gap with Java/JS SDKs. Depends on #5333 (merged) which addedIdGeneratortomodels.py.Fixes #5334
Changes
_ID_GENERATOR_REGISTRYand_create_id_generatorin_tracer_provider.pyusing the existing_resolve_componenthelperrandomresolves toRandomIdGeneratoropentelemetry_id_generatorentry point group (same groupOTEL_PYTHON_ID_GENERATORuses today)id_generatorthroughcreate_tracer_provider- absent config passesNoneso the SDK applies its ownRandomIdGeneratordefaultTests Added
test_absent_id_generator_uses_sdk_default- omitted config → SDK defaultRandomIdGeneratortest_builtin_random_id_generator- built-inrandom→RandomIdGeneratortest_plugin_id_generator_loaded_via_entry_point- unknown name → loaded fromopentelemetry_id_generatorentry point grouptest_unknown_id_generator_raises_configuration_error- unknown name with no matching entry point →ConfigurationErrortest_empty_id_generator_raises_configuration_error- empty config →ConfigurationErrorType of change
How Has This Been Tested?
tox -e ruff- linter and formatter passingDoes This PR Require a Contrib Repo Change?
Checklist: