Add ExponentialHistograms to data types supported - #4134
Merged
Conversation
aabmass
approved these changes
Aug 19, 2024
aabmass
left a comment
Member
There was a problem hiding this comment.
Thanks, we probably just missed it earlier.
Can you just add something to the PR description or a linked issue with context?
bogdandrutu
force-pushed
the
addexponentialhisto
branch
2 times, most recently
from
August 19, 2024 20:35
d9e6538 to
15764d6
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
addexponentialhisto
branch
from
August 20, 2024 00:04
15764d6 to
f983ae2
Compare
xrmx
approved these changes
Aug 20, 2024
emdneto
approved these changes
Aug 20, 2024
lzchen
approved these changes
Aug 20, 2024
hyoinandout
pushed a commit
to hyoinandout/opentelemetry-python
that referenced
this pull request
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExponentialHistogram support was added long time ago #2964, but the types were not properly exported and some linters will complain about this.
This PR exports the ExponentialHistogram and ExponentialHistogramDataPoint and marks the Metric.data to support this new types.