Skip to content

Update CODEOWNERS to include only python-approvers - #321

Merged
c24t merged 1 commit into
open-telemetry:masterfrom
c24t:make-codeowners-approvers
Dec 9, 2019
Merged

Update CODEOWNERS to include only python-approvers#321
c24t merged 1 commit into
open-telemetry:masterfrom
c24t:make-codeowners-approvers

Conversation

@c24t

@c24t c24t commented Dec 6, 2019

Copy link
Copy Markdown
Member

Make CODEOWNERS use https://github.com/orgs/open-telemetry/teams/python-approvers/members at @a-feld's suggestion.

The only effect of this change is to remove @a-feld -- who isn't currently active in this repo -- from CODEOWNERS.

@c24t c24t added the meta Related to repo itself, process, community, ... label Dec 6, 2019
codeboten
codeboten approved these changes Dec 6, 2019
View reviewed changes

@codeboten codeboten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io

codecov-io commented Dec 6, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #321 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   85.74%   85.88%   +0.14%     
==========================================
  Files          33       33              
  Lines        1613     1630      +17     
  Branches      181      182       +1     
==========================================
+ Hits         1383     1400      +17     
  Misses        182      182              
  Partials       48       48
Impacted Files Coverage Δ
...app/src/opentelemetry_example_app/flask_example.py 100% <0%> (ø) ⬆️
...src/opentelemetry/ext/opentracing_shim/__init__.py 95.86% <0%> (+0.17%) ⬆️
...xt-jaeger/src/opentelemetry/ext/jaeger/__init__.py 85.18% <0%> (+0.18%) ⬆️
...ry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py 90.54% <0%> (+0.26%) ⬆️
...ts/src/opentelemetry/ext/http_requests/__init__.py 89.18% <0%> (+0.3%) ⬆️
opentelemetry-sdk/src/opentelemetry/sdk/util.py 85.88% <0%> (+0.34%) ⬆️
...opentelemetry/sdk/context/propagation/b3_format.py 84.61% <0%> (+0.61%) ⬆️
...ry-sdk/src/opentelemetry/sdk/resources/__init__.py 70.83% <0%> (+2.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d441b1...e8fbcf8. Read the comment docs.

@toumorokoshi toumorokoshi added the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Dec 9, 2019
@c24t
c24t merged commit 1c8b9a2 into open-telemetry:master Dec 9, 2019
@c24t
c24t deleted the make-codeowners-approvers branch December 9, 2019 23:24
@c24t c24t removed the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes
@a-feld a-feld Awaiting requested review from a-feld
@lzchen lzchen Awaiting requested review from lzchen
@reyang reyang Awaiting requested review from reyang
+3 more reviewers
@codeboten codeboten codeboten approved these changes
@toumorokoshi toumorokoshi toumorokoshi approved these changes
@Oberon00 Oberon00 Oberon00 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Related to repo itself, process, community, ...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@c24t @codecov-io @codeboten @carlosalberto @toumorokoshi @Oberon00