Skip to content

Add InMemoryMetricReader to metrics SDK - #2540

Merged
ocelotl merged 2 commits into
open-telemetry:mainfrom
aabmass:2539-in-mem-exporter
Mar 22, 2022
Merged

Add InMemoryMetricReader to metrics SDK#2540
ocelotl merged 2 commits into
open-telemetry:mainfrom
aabmass:2539-in-mem-exporter

Conversation

@aabmass

@aabmass aabmass commented Mar 18, 2022

Copy link
Copy Markdown
Member

Description

Fixes #2539

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added unit test

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass added sdk Affects the SDK package. metrics labels Mar 18, 2022
@aabmass
aabmass requested a review from a team March 18, 2022 21:58
@aabmass
aabmass force-pushed the 2539-in-mem-exporter branch from 1665eae to 24561c6 Compare March 18, 2022 22:07
@aabmass
aabmass force-pushed the 2539-in-mem-exporter branch from 24561c6 to 2832f87 Compare March 18, 2022 22:13
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py
@lzchen

lzchen commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

@aabmass

The only thing missing there is a timeout which you would need a background thread/coroutine for regardless.

That's a good point. We can discuss on our recommendation of how to achieve the above scenario outside of this PR.

@ocelotl
ocelotl merged commit 95aeecc into open-telemetry:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metrics sdk Affects the SDK package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement InMemoryMetricExporter

3 participants