Make metrics api/sdk packages private *._metrics - #2249
Merged
Conversation
*._metrics
aabmass
marked this pull request as ready for review
October 28, 2021 21:26
codeboten
approved these changes
Oct 28, 2021
lzchen
approved these changes
Oct 28, 2021
Member
Author
|
@ocelotl PTAL and merge if it looks good to you |
ocelotl
approved these changes
Oct 29, 2021
This was referenced Oct 29, 2021
aabmass
added a commit
to aabmass/opentelemetry-python
that referenced
this pull request
Oct 29, 2021
* Make metrics api/sdk packages private `*._metrics` * add warning
ocelotl
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Make metrics api/sdk packages private `*._metrics` * add warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion in the issue here: #2233
Make metrics api/sdk packages private
*._metricsand rename everywhere. Also added a warning in the docs.