fix: documentation on "Well known exporters" and OTEL_TRACES_EXPORTER variable - #2023
Merged
Conversation
ecourreges-orange
requested review from
a team,
lzchen and
owais
and removed request for
a team
August 9, 2021 14:56
ocelotl
approved these changes
Aug 9, 2021
ocelotl
left a comment
Contributor
There was a problem hiding this comment.
Good catch, thanks for the fixes ✌️
codeboten
approved these changes
Aug 9, 2021
codeboten
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this!
srikanthccv
reviewed
Aug 9, 2021
| - otlp | ||
| - otlp_proto_grpc_span |
Contributor
There was a problem hiding this comment.
Good catch, that's correct, otlp_proto_grpc_span should stay.
codeboten
suggested changes
Aug 9, 2021
| - otlp | ||
| - otlp_proto_grpc_span |
Contributor
There was a problem hiding this comment.
Good catch, that's correct, otlp_proto_grpc_span should stay.
ocelotl
suggested changes
Aug 9, 2021
ocelotl
left a comment
Contributor
There was a problem hiding this comment.
Please fix the requested change ✌️
Contributor
Author
|
/
Actually it already says just below in the doc that otlp is an alias for otlp_proto_grpc_span but ok i can re-add it as well if you prefer. |
fix: documentation OTEL_TRACE_EXPORTER -> OTEL_TRACES_EXPORTER
ecourreges-orange
force-pushed
the
main
branch
from
August 10, 2021 07:33
b88af7c to
1b771ee
Compare
lzchen
approved these changes
Aug 10, 2021
Contributor
|
Will review tonight ✌️ |
ocelotl
approved these changes
Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the auto-instrumentation README and examples, I encountered 2 inconsistencies between doc and code, so I fixed the documentation:
fix: documentation on "Well known exporters" -> zipkin doesn't exist but zipkin_json and zipkin_proto exist, etc. Thanks @ocelotl
fix: documentation env var is not OTEL_TRACE_EXPORTER but OTEL_TRACES_EXPORTER