Repository navigation
To Handle non string keys in CaseInsensitiveMap'get - #9003
Open
NithinU2802 wants to merge 1 commit into
Open
NithinU2802 wants to merge 1 commit into
NithinU2802 wants to merge 1 commit into
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-03 13:54 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9003 +/- ##
============================================
- Coverage 90.39% 90.38% -0.01%
+ Complexity 10997 10996 -1
============================================
Files 1020 1020
Lines 30096 30098 +2
Branches 3929 3929
============================================
- Hits 27204 27203 -1
Misses 1937 1937
- Partials 955 958 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to handle non string keys in CaseInsensitiveMap'get, currently CaseInsensitiveMap.get(Object) lowercases keys by casting them to String. As a result, looking up a null or non-string key could throw exceptions instead of returning null, as expected from a map lookup.
Return null for keys that aren’t strings, while preserving case insensitive lookup for string keys, also added tests for null and non-string keys.