Fix javadoc examples in context propagation interfaces - #8715
Open
thswlsqls wants to merge 1 commit into
Open
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-08-10 01:36 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8715 +/- ##
=========================================
Coverage 91.65% 91.65%
- Complexity 10352 10353 +1
=========================================
Files 1003 1003
Lines 27210 27210
Branches 3199 3199
=========================================
+ Hits 24939 24940 +1
Misses 1566 1566
+ Partials 705 704 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TextMapPropagatorandContextPropagatorsuse pre-1.0 API names, so copying them does not compile.Setter/Getterno longer exist: the types areTextMapSetter<C>/TextMapGetter<C>, and the setter method isset, notput.get(with noreturn) and omitted the requiredkeys; it now mirrorsExtendedContextPropagators.TEXT_MAP_GETTER.Context.Key,Context.key(...),ContextKey.get(context)andcontext.withValue(...)becomeContextKey.named(...),context.get(key)andcontext.with(key, value).MyConcernPropagatorwas missing theclasskeyword, used an undeclaredconcern, and did not implement the abstractfields().HttpTraceContextwas removed in 1.0; the composite example now usesW3CTraceContextPropagator.getInstance().ContextPropagatorsblock but leftSetter/Getter/HttpTraceContextbehind.Testing done
./gradlew :context:checkpassed, anddocs/apidiffs/current_vs_latest/*.txtis unchanged.javacagainst:contextand:api:all— every type and signature resolves../gradlew :context:javadoc --rerun-tasks— BUILD SUCCESSFUL, noinvalid-tagin the generated HTML.