Add FOSSA license scanning#7090
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7090 +/- ##
============================================
+ Coverage 89.85% 89.86% +0.01%
Complexity 6613 6613
============================================
Files 740 740
Lines 19991 19991
Branches 1966 1966
============================================
+ Hits 17962 17964 +2
+ Misses 1438 1437 -1
+ Partials 591 590 -1 ☔ View full report in Codecov by Sentry. |
jkwatson
approved these changes
Feb 9, 2025
jack-berg
reviewed
Feb 10, 2025
|
|
||
|
|
||
| val DEPENDENCIES = listOf( | ||
| "org.junit.jupiter:junit-jupiter-api:5.11.4", |
Member
There was a problem hiding this comment.
Can we follow the armeria pattern and explicitly add dependency versions here for each of the junit components we use? I.e.:
"org.junit.jupiter:junit-jupiter-api:${junitVersion}",
"org.junit.jupiter:junit-jupiter-params:${junitVersion}",
"org.junit.jupiter:junit-jupiter-pioneer:${junitVersion}",
If we can, we should try to retain the pattern of establishing all dependency versions here and not letting the junit dependency version leak into otel-java-conventions.gradle.kts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.