Skip to content

Release workflow fixes - #4361

Merged
anuraaga merged 2 commits into
open-telemetry:mainfrom
trask:fix-release-workflow
Apr 11, 2022
Merged

Release workflow fixes#4361
anuraaga merged 2 commits into
open-telemetry:mainfrom
trask:fix-release-workflow

Conversation

@trask

@trask trask commented Apr 8, 2022

Copy link
Copy Markdown
Member
  • heredoc problems in the scripts
  • trying to use the release tag before it was made (when calling generate-release-contributors.sh)
  • chmod +x for generate-release-contributors.sh
  • usage of $version instead of $VERSION in a couple of places

@trask
trask requested a review from a user April 8, 2022 20:21
@trask
trask requested a review from Oberon00 as a code owner April 8, 2022 20:21
@codecov

codecov Bot commented Apr 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4361 (3c404b8) into main (44afb13) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4361      +/-   ##
============================================
+ Coverage     89.92%   89.96%   +0.03%     
- Complexity     4897     4900       +3     
============================================
  Files           568      568              
  Lines         15172    15172              
  Branches       1461     1461              
============================================
+ Hits          13644    13649       +5     
+ Misses         1057     1055       -2     
+ Partials        471      468       -3     
Impacted Files Coverage Δ
...metry/exporter/internal/marshal/MarshalerUtil.java 91.00% <0.00%> (+2.00%) ⬆️
...elemetry/exporter/internal/marshal/Serializer.java 79.78% <0.00%> (+2.12%) ⬆️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44afb13...3c404b8. Read the comment docs.

trask added a commit to trask/opentelemetry-java-contrib that referenced this pull request Apr 10, 2022
@anuraaga
anuraaga merged commit 8eec1b3 into open-telemetry:main Apr 11, 2022
trask added a commit to open-telemetry/opentelemetry-java-instrumentation that referenced this pull request Apr 11, 2022
* Port open-telemetry/opentelemetry-java#4353

* Port open-telemetry/opentelemetry-java#4359

* Port open-telemetry/opentelemetry-java#4361

* Port open-telemetry/opentelemetry-java#4362

* More syncing

* And sync markdown link check

Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
trask added a commit to open-telemetry/opentelemetry-java-contrib that referenced this pull request Apr 11, 2022
@trask
trask deleted the fix-release-workflow branch April 22, 2022 17:27
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants