Update errorprone#4346
Merged
Merged
Conversation
anuraaga
commented
Apr 7, 2022
|
|
||
| private final LongAdder count = new LongAdder(); | ||
| private final LongAdder totalTime = new LongAdder(); | ||
| private final DoubleAdder totalTime = new DoubleAdder(); |
Contributor
Author
There was a problem hiding this comment.
Since micrometer bridge is all about recording doubles, figured this is more appropriate than multiple conversions
Codecov Report
@@ Coverage Diff @@
## main #4346 +/- ##
============================================
- Coverage 89.91% 89.89% -0.02%
Complexity 4888 4888
============================================
Files 568 568
Lines 15152 15156 +4
Branches 1461 1461
============================================
+ Hits 13624 13625 +1
- Misses 1055 1058 +3
Partials 473 473
Continue to review full report at Codecov.
|
mateuszrzeszutek
approved these changes
Apr 7, 2022
jack-berg
approved these changes
Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://errorprone.info/bugpattern/LongDoubleConversion