Rename newBuilder to builder for consistency.#1790
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1790 +/- ##
============================================
- Coverage 85.94% 85.92% -0.02%
+ Complexity 1379 1378 -1
============================================
Files 166 166
Lines 5307 5307
Branches 549 549
============================================
- Hits 4561 4560 -1
Misses 551 551
- Partials 195 196 +1
Continue to review full report at Codecov.
|
jkwatson
approved these changes
Oct 13, 2020
jkwatson
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Consistency is important in the API to reduce confusion.
carlosalberto
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently are not consistent with whether we use
newBuilderorbuilderfor a builder factory. This consolidates onbuilder, similar to Guava and slightly recommended by AutoValue.