Migrate tests to JUnit5#1489
Merged
Merged
Conversation
added 2 commits
July 31, 2020 18:14
jkwatson
approved these changes
Jul 31, 2020
jkwatson
left a comment
Contributor
There was a problem hiding this comment.
This PR makes me very very happy. Thanks for taking this on!
carlosalberto
approved these changes
Jul 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few tests that use JUnit4
Rulefor gRPC and log4j are left but the rest are migrated.Mostly just used IntelliJ Structural Replace and Replace in Path with some manual Rule replacement.
This doesn't build locally for me without #1488
For #1452