Repository navigation
Added Kafka worker-side consumer logic - #342
Merged
tylerharter merged 8 commits intoOct 20, 2025
Merged
tylerharter merged 8 commits into
tylerharter merged 8 commits into
Conversation
Yashwanth-Ranjan-Singaravel
requested review from
Mandukhai-Alimaa and
tylerharter
September 30, 2025 09:58
Contributor
Author
|
I'll definitely clean up the code by removing redundant comments and logging statements before I mark this as ready! |
tylerharter
requested changes
Sep 30, 2025
tylerharter
reviewed
Oct 2, 2025
| } | ||
|
|
||
| if header.Name == LambdaConfigFilename { | ||
| // Check if this is the config file handle exact matches (ol.yaml) |
tylerharter
requested changes
Oct 2, 2025
Yashwanth-Ranjan-Singaravel
marked this pull request as ready for review
October 9, 2025 10:13
tylerharter
reviewed
Oct 9, 2025
| slog.Info("Received kill signal, cleaning up.") | ||
| shutdown(pidPath, s) | ||
|
|
||
| // Clean up all resources in order |
Member
There was a problem hiding this comment.
redundant with other case? Let's have one way we cleanup (probably the other code). For that to run, though, Main needs to return. Which means ListenAndServe needs to return. Which means we need to close the mux. But perhaps that is tricky if we're using the default? Bridget already has feedback about using non-defaults for both the servers: https://github.com/open-lambda/open-lambda/pull/343/files. Let's coordinate.
tylerharter
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logic to run Kafka consumers during startup of workers that can act as triggers to invoke lambda functions on new messages from configured brokers.