Skip to content

feat: Cache hooks per Flag Evaluation Type #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrfwow wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: Cache hooks per Flag Evaluation Type #1734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
df49024
add bench
chrfwow Sep 15, 2025
ea3990d
fix bench
chrfwow Sep 15, 2025
1e7ee96
Merge branch 'refs/heads/main' into cache-baseline
chrfwow Oct 15, 2025
9d49b91
merge master
chrfwow Oct 15, 2025
628eda6
improve benchmark
chrfwow Nov 12, 2025
2e9af46
improve benchmark
chrfwow Nov 12, 2025
b9fc776
add str hook for ctx
chrfwow Nov 19, 2025
8a0770e
cache hooks
chrfwow Nov 20, 2025
64a81fb
Merge branch 'refs/heads/main' into cached-hooks
chrfwow Nov 20, 2025
b5a443f
cache hooks
chrfwow Nov 20, 2025
ba8f6bc
extract common code
chrfwow Nov 24, 2025
8f9da44
spotless
chrfwow Nov 24, 2025
59530f5
revert comments
chrfwow Nov 25, 2025
5300c9d
Merge remote-tracking branch 'origin/main' into cached-hooks
chrfwow Dec 16, 2025
22ff9ce
merge main and improvements
chrfwow Dec 16, 2025
277cbe0
format
chrfwow Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
format 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
  • Loading branch information
@chrfwow
chrfwow committed Dec 16, 2025
commit 277cbe0faf67cddeb8cd3adb111d546f7556d783
16 changes: 10 additions & 6 deletions src/test/java/dev/openfeature/sdk/HookSupportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ void shouldPassDataAcrossStages(FlagValueType flagValueType) {
Collections.emptyList(),
new ConcurrentLinkedQueue<>(),
new ConcurrentLinkedQueue<>());
hookSupport.setHookContexts(hookSupportData, getBaseHookContextForType(flagValueType),
LayeredEvaluationContext.empty());
hookSupport.setHookContexts(
hookSupportData, getBaseHookContextForType(flagValueType), LayeredEvaluationContext.empty());

hookSupport.executeBeforeHooks(hookSupportData);
assertHookData(testHook, "before");
Expand Down Expand Up @@ -121,8 +121,8 @@ void shouldIsolateDataBetweenHooks(FlagValueType flagValueType) {
Collections.emptyList(),
new ConcurrentLinkedQueue<>(),
new ConcurrentLinkedQueue<>());
hookSupport.setHookContexts(hookSupportData, getBaseHookContextForType(flagValueType),
LayeredEvaluationContext.empty());
hookSupport.setHookContexts(
hookSupportData, getBaseHookContextForType(flagValueType), LayeredEvaluationContext.empty());

callAllHooks(hookSupportData);

Expand All @@ -148,8 +148,12 @@ public Optional<EvaluationContext> before(HookContext ctx, Map hints) {
var layeredEvaluationContext =
new LayeredEvaluationContext(evaluationContextWithValue("key", "value"), null, null, null);
hookSupportData.evaluationContext = layeredEvaluationContext;
hookSupport.setHooks(hookSupportData, List.of(recursiveHook, emptyHook), Collections.emptyList(),
new ConcurrentLinkedQueue<>(), new ConcurrentLinkedQueue<>());
hookSupport.setHooks(
hookSupportData,
List.of(recursiveHook, emptyHook),
Collections.emptyList(),
new ConcurrentLinkedQueue<>(),
new ConcurrentLinkedQueue<>());
hookSupport.setHookContexts(
hookSupportData, getBaseHookContextForType(FlagValueType.STRING), layeredEvaluationContext);

Expand Down
2 changes: 1 addition & 1 deletion src/test/java/dev/openfeature/sdk/OpenFeatureClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
import dev.openfeature.sdk.fixtures.HookFixtures;
import dev.openfeature.sdk.testutils.testProvider.TestProvider;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.List;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
Expand Down
Loading