Skip to content
This repository was archived by the owner on Feb 21, 2019. It is now read-only.

fixed bug #83#84

Merged
onevcat merged 1 commit into
onevcat:masterfrom
maogm12:master
Jan 28, 2015
Merged

fixed bug #83#84
onevcat merged 1 commit into
onevcat:masterfrom
maogm12:master

Conversation

@maogm12

@maogm12 maogm12 commented Jan 27, 2015

Copy link
Copy Markdown
Contributor

In check swift function:

return ![self vv_isObjCMethod] && ![self vv_isSwiftProperty] && [self vv_matchesPatternRegexPattern:@"^\\s*(.*\\s+)?(func\\s+)|(init|deinit)"];

will do swift property check first in which only var/let is used, so swift function check will fail when var/let type of params is used.

The fix make some change in swift property check:

return [self vv_matchesPatternRegexPattern:@"^\\s*([^(]*?)(((\\s*let|var\\s*)\\s+)|(\\(\\s*set\\s*\\)))"];

because in property declaration, ( appearing before let/var only happens when private(set) or internal(set) is used

@onevcat

onevcat commented Jan 27, 2015

Copy link
Copy Markdown
Owner

Hi, @garnel Fantastic!
Thank you. And before I can merge it, could I ask you for modifying the format in VVMethodTestsCode.plist?

I noticed some spaces are replaced by tab by accident. Would you please help to change them back to space? (And also use space in new test case) Thank you.

@maogm12

maogm12 commented Jan 27, 2015

Copy link
Copy Markdown
Contributor Author

@onevcat OK! I'll do it right away

onevcat added a commit that referenced this pull request Jan 28, 2015
@onevcat onevcat merged commit 9844fee into onevcat:master Jan 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants