Skip to content

fix: replace raw Go errors with user-friendly messages #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnnyfish merged 1 commit into from
May 9, 2026
Merged

fix: replace raw Go errors with user-friendly messages #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/onecli/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package main
import (
"bufio"
"errors"
"fmt"
"os"
"strings"

Expand Down Expand Up @@ -60,7 +61,11 @@ func (c *AuthLoginCmd) Run(out *output.Writer) error {
client := api.New(config.APIHost(), apiKey)
user, err := client.GetUser(newContext())
if err != nil {
return errors.New("invalid API key: authentication failed")
var apiErr *api.APIError
if errors.As(err, &apiErr) && apiErr.StatusCode == 401 {
return errors.New("invalid API key: the server rejected this key")
}
return fmt.Errorf("could not verify API key: %w", err)
}

// Store the key.
Expand Down
4 changes: 2 additions & 2 deletions cmd/onecli/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func (c *RunCmd) Run(out *output.Writer) error {
// Resolve the binary path early — fail fast before the API round-trip.
binary, err := exec.LookPath(c.Args[0])
if err != nil {
return fmt.Errorf("command not found %s: %w", c.Args[0], err)
return fmt.Errorf("command not found: %s — is it installed and in your PATH?", c.Args[0])
}

// Fetch gateway configuration from the API.
Expand Down Expand Up @@ -124,7 +124,7 @@ func (c *RunCmd) Run(out *output.Writer) error {
// Exec — replaces this process so the agent gets direct terminal control.
out.Stderr(fmt.Sprintf("onecli: gateway connected. Starting %s...", c.Args[0]))
if err := syscall.Exec(binary, c.Args, env); err != nil {
return fmt.Errorf("exec %s: %w", binary, err)
return fmt.Errorf("could not start %s: %w", c.Args[0], err)
}
return nil
}
Expand Down
2 changes: 1 addition & 1 deletion internal/api/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (c *Client) do(ctx context.Context, method, path string, body any, result a

if result != nil {
if err := json.Unmarshal(respBody, result); err != nil {
return fmt.Errorf("decoding response: %w", err)
return fmt.Errorf("unexpected response from server (status %d) — expected JSON", resp.StatusCode)
}
}
return nil
Expand Down
Loading