scope gateway cors to the dashboard origin - #473
Open
ben564885 wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #472.
the gateway reflected any cors origin with credentials on, so any website could drive the authenticated browser api — in local mode the auth extractor resolves
local-adminfrom no request state. this replacesalloworigin::mirror_request()with an exact match on the dashboard's own origin (app_url, else the loopback fallback) viaresponse::dashboard_url().verified in a real browser: before, a page on another origin read and approved a pending human-approval; after, the same page is blocked by cors while the legitimate dashboard origin still works. all 519 gateway tests pass, plus a regression test.