Restore Reconnect action for GitHub App connections - #469
Open
erichanwang wants to merge 1 commit into
Open
Conversation
connection-account-card.tsx hid the Reconnect menu item entirely whenever a connection's metadata carried a manageUrl (only github-app sets this), replacing it with a direct link to the existing GitHub installation settings page. That's the "silent" failure from onecli#403: users had no way to trigger a fresh OAuth flow, and the only available action dumped them on github.com with no explanation. Reconnect is now always available. For github-app connections it first confirms, since GitHub short-circuits the OAuth callback back to the installation settings page when the app is already installed — the dialog explains that and links to the settings page to uninstall first. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XrcMxXTRMo1C8t4AyUJor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #403
changes
connection-account-card.tsxwas hiding the "Reconnect" menu item entirely whenever a connection's metadata carried amanageUrl— onlygithub-appsets this — replacing it with a direct link to the existing GitHub installation settings page. That's the root cause of the silent failure in GitHub App (BYOC): Reconnect navigates to existing installation page instead of triggering fresh auth flow #403: the only action available for a connected GitHub App sent users straight to github.com with no explanation and no way to trigger a fresh OAuth flow.manageUrl(GitHub App), clicking Reconnect first shows a confirmation dialog explaining that GitHub short-circuits the OAuth callback back to the installation settings page when the app is already installed, with a link to open those settings and uninstall before reconnecting.verification
pnpm --filter web check-typespnpm --filter web lintgit diff --checkpnpm check(full monorepo lint + check-types + format:check, ran via pre-commit hook)