feat: live approval notifications, gateway summaries, and fixes - #393
Merged
Conversation
Approvals - Live pending-approval notifications: a header bell + popover surface requests the gateway is holding, each with a countdown to auto-deny. - Approver audit: who approved/denied a request now shows in the activity table and detail dialog. - Gateway: pluggable per-app approval summaries describing what a held request will do, with friendly titles for all major Gmail and Google Calendar APIs. Fixes - App-permission catalogs: correct patterns that silently never matched. - Secrets: reject public-suffix wildcards in host patterns (adds tldts). - Auth: scope project access by organization role. - Gateway cache: flush on bulk/cascade delete paths. Also adds a shadcn popover component and a vitest suite for secret host-pattern validation.
nbmorgan
added a commit
to nbmorgan/onecli
that referenced
this pull request
Jun 27, 2026
… ntfy channel Align the ntfy push channel with upstream onecli#393's approval summaries + bell: - ntfy notification now renders the gateway's structured ApprovalSummary (the same "Send email · To: … · Subject: …" the dashboard bell shows) as the title + body, falling back to the legacy body preview then a generic line. A footer always names the agent + target. - The "Report Selection to Topic" confirmation note now fires on ANY resolution via a shared helper — not just the ntfy tap but also a dashboard/SDK decision (labelled "via dashboard"), so ntfy subscribers learn when someone ELSE approved. Carries the decision + original request name/time. - Settings copy: the OneCLI SDK card now names the dashboard approvals bell as its surface. Keeps the Approval Paths channel framework as the home for delivery channels (bell = onecli channel, ntfy = push channel). A generalized notifier registry is left for upstream to decide. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nbmorgan
added a commit
to nbmorgan/onecli
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approvals
Fixes
*.com) in host match patterns; addstldtsfor public-suffix detection.Misc
popoverUI component.vitestsuite covering secret host-pattern validation (14 cases).