Skip to content

removed ext::oneapi namespace in Jupyter DPC++ Reduction code samples - #779

Merged
praveenkk123 merged 2 commits into
oneapi-src:developmentfrom
krisrak:20211202-dpcpp-reductions
Dec 3, 2021
Merged

removed ext::oneapi namespace in Jupyter DPC++ Reduction code samples#779
praveenkk123 merged 2 commits into
oneapi-src:developmentfrom
krisrak:20211202-dpcpp-reductions

Conversation

@krisrak

@krisrak krisrak commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Existing Sample Changes

Description

removed ext::oneapi namespace in Reduction code samples, the reduction is implemented under sycl namespace

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Command Line

@krisrak

krisrak commented Dec 2, 2021

Copy link
Copy Markdown
Contributor Author

@praveenkk123 this works in 2021.4, please approve CI run and merge

@praveenkk123 praveenkk123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

@praveenkk123 praveenkk123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

@praveenkk123
praveenkk123 merged commit 937b930 into oneapi-src:development Dec 3, 2021
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
…#779)

* removed ext::oneapi namespace in Jupyter DPC++ Reduction code samples

* updated Makefile with Reduction cpp file name changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants