Rendering toolkit oidn code sample PR by MichaelRoyceCarroll · Pull Request #713 · oneapi-src/oneAPI-samples

MichaelRoyceCarroll · 2021-10-18T22:32:12Z

Adding a New Sample(s)

Description

New sample PR for oneapi rendering toolkit oidn sample. (library # 4 of 4)
See isseue: #697

Checklist

Administrative

Review sample design with the appropriate Domain Expert:
If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager: @JoeOster

Code Development

Implement coding guidelines and ensure code quality. see wiki for details
Adhere to readme template
Enforce format via clang-format config file
Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
Run jsonlint on sample.json to verify json syntax. www.jsonlint.com

Security and Legal

OSPDT Approval (see @JoeOster for assistance)
Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
Bandit Scans (Python only)
Virus scan

Review

Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
Review readme with Tom Lenth(@tomlenth) and/or Joe Oster(@JoeOster)
Tested using Dev Cloud when applicable

* Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…ed commit) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Moving README.md content to individual folders

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…roll/oneAPI-samples into RenderingToolkit

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…get stuck. It is not too big. Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

JoeOster · 2021-10-18T23:18:24Z

+- Open Image Denoise
+
+Imaging Tools:
+- An image **display program** for .ppm and .pfm filetypes . Ex: [ImageMagick](https://www.imagemagick.org/)


I think this should read as "A image viewer..."

@JoeOster Thanks for the review. Per grammar rules I think 'an image display program' is correct... Reference: https://www.thesaurus.com/e/grammar/a-vs-an/
However, if you believe there is a readability issue I can think about a different description.

This has been changed to use the mandlebrot style README file table. This is now no longer applicable.

JoeOster · 2021-10-19T15:52:20Z

OSPDT Approved per OSPDT-1015 * All Apache Licensed libraries distributed as part of oneAPI have been approved
OIDN is part of the oneAPI Rendering Toolkit

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI purposes only

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI purposes again

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI

…ges (OK) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI

praveenkk123

Approve for CI

MichaelRoyceCarroll · 2021-10-28T00:35:13Z

@Yury-B Is CMake not available for MacOS? Can it be?

Yury-B · 2021-10-28T16:03:42Z

@Yury-B Is CMake not available for MacOS? Can it be?

now, cmake 3.21 is available in /usr/local/bin

MichaelRoyceCarroll · 2021-10-28T17:09:40Z

@Yury-B Is CMake not available for MacOS? Can it be?

now, cmake 3.21 is available in /usr/local/bin

Thanks I should be able to fix the latest issue with the std toggle.

-MichaelC

praveenkk123

Approve for CI

MichaelRoyceCarroll · 2021-10-29T21:10:08Z

This one I still need to fix... lost track of the toggle amongst other changes... WIP

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…ceCarroll/oneAPI-samples into RenderingToolkit-oidn

praveenkk123

Approve for CI

MichaelRoyceCarroll · 2021-11-01T23:33:01Z

Hello... 0b20e73 'may' be a workaround for oidn dyld not loading issue. Can we launch it? Thanks.

praveenkk123

Approve for CI

* ONSAM-1414 Broken Link in Headers (#685) * Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp * fix deprecation notice (#682) * initial commit for RenderingToolkit GSG sample proposal * signed inital commit for RenderingToolkit GSG intro samples Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README.md Moving README.md content to individual folders * Order samples folders Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README.md * Adding per sample component README.md files Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README.md * Adding percomponent LICENSE placeholder files (to be reviewed) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Adding converted .pfm input file. This file could help users if they get stuck. It is not too big. Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Updating sample.json files per Joseph Oster guidance Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Updates to oidn README.md for linux and macos Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README for library requirements Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * New branch for just oidn sample Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Add description to base README.md Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * removing overlapping content. overlap to RenderingToolkit-ospray branch Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Updates for the oidn README.md Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * clang-format for source Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * README.md update Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Triage samples.json for CI process. Hopefully this unblocks! Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Escape the spaces for CI in sample.json Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Escape extra quotes for CI in sample.json Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Should be no Release folder for sample.json on macos or lin. It has been removed Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Escapes for sample.json input files and exe invoke Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * README.md updates for better pathing and simplified build Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * CMakeLists convenience updates Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Changing paths for better CI Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Nameing in CMakeLists for global variables build fix Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update sample.json to take our oneapi env... check paths to input images (OK) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * fix typo/text ommission in sample.json to unblock CI Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update sample.json * sample.json to match for macos (env vars) * Healthier CMakeLists for macos and c++11 on all platforms Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update samples.json for better Macos env vars... (CI Only) Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com> Co-authored-by: ericlars <eric.larson@intel.com>

JoeOster and others added 18 commits September 29, 2021 09:45

ONSAM-1414 Broken Link in Headers (oneapi-src#685)

8e0bdb3

* Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp

fix deprecation notice (oneapi-src#682)

4bed52e

initial commit for RenderingToolkit GSG sample proposal

b23d63a

signed inital commit for RenderingToolkit GSG intro samples

f0a1b50

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (sign…

9fa62ea

…ed commit) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update README.md

be21e94

Moving README.md content to individual folders

Order samples folders

78b2bff

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update README.md

8990739

Adding per sample component README.md files

fb7dcf2

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Merge branch 'RenderingToolkit' of https://github.com/MichaelRoyceCar…

002b232

…roll/oneAPI-samples into RenderingToolkit

Update README.md

d85d358

Adding percomponent LICENSE placeholder files (to be reviewed)

507eb04

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Adding converted .pfm input file. This file could help users if they …

b738b26

…get stuck. It is not too big. Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Updating sample.json files per Joseph Oster guidance

5f91694

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Updates to oidn README.md for linux and macos

a3461c3

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update README for library requirements

86c8200

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

New branch for just oidn sample

2c6f167

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Add description to base README.md

6c7e27c

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

JoeOster linked an issue Oct 18, 2021 that may be closed by this pull request

Request to Add a oneAPI Sample: Initial Rendering Toolkit sample #697

Closed

JoeOster suggested changes Oct 18, 2021

View reviewed changes

MichaelRoyceCarroll changed the base branch from master to development October 18, 2021 23:39

MichaelRoyceCarroll changed the title ~~Rendering toolkit oidn~~ Rendering toolkit oidn code sample PR Oct 19, 2021

Merge branch 'development' into RenderingToolkit-oidn

506c255

JoeOster added the OSPDT Approved label Oct 19, 2021

MichaelRoyceCarroll added 3 commits October 19, 2021 14:19

.repo-tools/Docs_Automation/guids.json merge fixes

e5b18de

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Attempting to merge all .repo-tools/Docs_Automation/guids.json

4701fed

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

removing overlapping content. overlap to RenderingToolkit-ospray branch

f02d1af

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Oct 21, 2021

View reviewed changes

Updates for the oidn README.md

c01aebb

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Escapes for sample.json input files and exe invoke

186d13c

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Oct 22, 2021

View reviewed changes

MichaelRoyceCarroll added 4 commits October 26, 2021 14:45

README.md updates for better pathing and simplified build

1ada59d

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

CMakeLists convenience updates

3bdf3cb

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Changing paths for better CI

339b71f

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Nameing in CMakeLists for global variables build fix

2c6f568

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Oct 26, 2021

View reviewed changes

MichaelRoyceCarroll added 2 commits October 26, 2021 16:30

Update sample.json to take our oneapi env... check paths to input ima…

4e069ba

…ges (OK) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

fix typo/text ommission in sample.json to unblock CI

c754c49

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Oct 27, 2021

View reviewed changes

Update sample.json

636c00b

praveenkk123 approved these changes Oct 27, 2021

View reviewed changes

MichaelRoyceCarroll mentioned this pull request Oct 28, 2021

Rendering toolkit embree code sample PR #710

Merged

15 tasks

praveenkk123 requested a review from pmpeter1 October 28, 2021 23:12

sample.json to match for macos (env vars)

896b376

praveenkk123 approved these changes Oct 29, 2021

View reviewed changes

MichaelRoyceCarroll added 2 commits October 29, 2021 16:56

Healthier CMakeLists for macos and c++11 on all platforms

9f483f6

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Merge branch 'RenderingToolkit-oidn' of https://github.com/MichaelRoy…

c19a921

…ceCarroll/oneAPI-samples into RenderingToolkit-oidn

praveenkk123 approved these changes Nov 1, 2021

View reviewed changes

pmpeter1 approved these changes Nov 1, 2021

View reviewed changes

Update samples.json for better Macos env vars... (CI Only)

0b20e73

praveenkk123 approved these changes Nov 1, 2021

View reviewed changes

praveenkk123 approved these changes Nov 3, 2021

View reviewed changes

praveenkk123 merged commit 783bd6b into oneapi-src:development Nov 3, 2021

Conversation

MichaelRoyceCarroll commented Oct 18, 2021

Adding a New Sample(s)

Description

Checklist

Uh oh!

JoeOster Oct 18, 2021

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll Oct 19, 2021

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll Oct 21, 2021

Choose a reason for hiding this comment

Uh oh!

JoeOster commented Oct 19, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll commented Oct 28, 2021

Uh oh!

Yury-B commented Oct 28, 2021

Uh oh!

MichaelRoyceCarroll commented Oct 28, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll commented Oct 29, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll commented Nov 1, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants