Rendering toolkit ospray code sample PR by MichaelRoyceCarroll · Pull Request #711 · oneapi-src/oneAPI-samples

MichaelRoyceCarroll · 2021-10-18T22:27:00Z

Adding a New Sample(s)

Description

New sample PR for oneapi rendering toolkit ospray sample. (library # 1 of 4)
See issue: #697

Checklist

Administrative

Review sample design with the appropriate Domain Expert:
If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager: @JoeOster

Code Development

Implement coding guidelines and ensure code quality. see wiki for details
Adhere to readme template
Enforce format via clang-format config file
Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
Run jsonlint on sample.json to verify json syntax. www.jsonlint.com

Security and Legal

OSPDT Approval (see @JoeOster for assistance)
Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
Bandit Scans (Python only)
Virus scan

Review

Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
Review readme with Tom Lenth(@tomlenth) and/or Joe Oster(@JoeOster)
Tested using Dev Cloud when applicable

* Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…ed commit) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Moving README.md content to individual folders

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…roll/oneAPI-samples into RenderingToolkit

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…get stuck. It is not too big. Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI process only

JoeOster · 2021-10-19T16:13:12Z

OSPDT Approved per OSPDT-1015 * All Apache Licensed libraries distributed as part of oneAPI have been approved
ospray is part of the oneAPI Rendering Toolkit

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

MichaelRoyceCarroll · 2021-10-21T22:21:04Z

This diff has the set-wise (set of 4 library gsg samples)... README.md included as well as the global GUID file updates.

…sample.json Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…een removed Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI purposes only

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI

praveenkk123

Approve for CI

MichaelRoyceCarroll · 2021-10-29T17:25:01Z

Hello @praveenkk123... I had a misnomer likely prohibiting execution of the macos CI for this PR. I made a checkin that should unblock macos.

praveenkk123

Approve for CI

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

MichaelRoyceCarroll · 2021-11-01T21:11:07Z

Added a fix for MacOS rkcommon error: #711 (comment)

praveenkk123

Approve for CI

MichaelRoyceCarroll · 2021-11-01T22:46:08Z

Progress here... I think I can make the same sample.json change that was just made for #712 to unblock Macos

praveenkk123

Approve for CI

* ONSAM-1414 Broken Link in Headers (#685) * Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp * fix deprecation notice (#682) * initial commit for RenderingToolkit GSG sample proposal * signed inital commit for RenderingToolkit GSG intro samples Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README.md Moving README.md content to individual folders * Order samples folders Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README.md * Adding per sample component README.md files Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README.md * Adding percomponent LICENSE placeholder files (to be reviewed) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Adding converted .pfm input file. This file could help users if they get stuck. It is not too big. Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Updating sample.json files per Joseph Oster guidance Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Updates to oidn README.md for linux and macos Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README for library requirements Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * New branch for just OSPRay sample Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Add description to base README.md Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Documentation updates Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * clang-format for source Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Escape extra quotes for CI and get the correct ospTutorialCpp.exe in sample.json Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Should be no Release folder for sample.json on macos or lin. It has been removed Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Escape for accurate exe invoke Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * README.md ospray updates... and some root GSG file staging Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * staging ospray for better heirarchy for CI Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * CMakeLists updates for better CI Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * CMakeLists.txt update for variable consistency Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update sample.json * sample.json fixes similar to embree...: remove env, fix pathing * Health fixes for cmakelists Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Fix MacOS: Update for rkcommon support lib CMakeLists search path Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Hopefully better pathing for macos oneapi rk runtime libs (CI only fix) Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com> Co-authored-by: ericlars <eric.larson@intel.com>

JoeOster and others added 18 commits September 29, 2021 09:45

ONSAM-1414 Broken Link in Headers (oneapi-src#685)

8e0bdb3

* Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp

fix deprecation notice (oneapi-src#682)

4bed52e

initial commit for RenderingToolkit GSG sample proposal

b23d63a

signed inital commit for RenderingToolkit GSG intro samples

f0a1b50

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (sign…

9fa62ea

…ed commit) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update README.md

be21e94

Moving README.md content to individual folders

Order samples folders

78b2bff

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update README.md

8990739

Adding per sample component README.md files

fb7dcf2

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Merge branch 'RenderingToolkit' of https://github.com/MichaelRoyceCar…

002b232

…roll/oneAPI-samples into RenderingToolkit

Update README.md

d85d358

Adding percomponent LICENSE placeholder files (to be reviewed)

507eb04

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Adding converted .pfm input file. This file could help users if they …

b738b26

…get stuck. It is not too big. Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Updating sample.json files per Joseph Oster guidance

5f91694

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Updates to oidn README.md for linux and macos

a3461c3

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update README for library requirements

86c8200

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

New branch for just OSPRay sample

5762071

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Add description to base README.md

a9a3bbc

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

MichaelRoyceCarroll changed the title ~~Rendering toolkit ospray~~ Rendering toolkit ospray code sample PR Oct 18, 2021

JoeOster linked an issue Oct 18, 2021 that may be closed by this pull request

Request to Add a oneAPI Sample: Initial Rendering Toolkit sample #697

Closed

MichaelRoyceCarroll changed the base branch from master to development October 18, 2021 23:39

praveenkk123 approved these changes Oct 19, 2021

View reviewed changes

JoeOster added the OSPDT Approved label Oct 19, 2021

MichaelRoyceCarroll added 3 commits October 19, 2021 15:04

Attempting to merge all .repo-tools/Docs_Automation/guids.json

382ef46

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Documentation updates

28e1c3d

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

clang-format for source

d7d5004

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

MichaelRoyceCarroll added 2 commits October 21, 2021 17:19

Escape extra quotes for CI and get the correct ospTutorialCpp.exe in …

1a87db6

…sample.json Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Should be no Release folder for sample.json on macos or lin. It has b…

a17a167

…een removed Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Escape for accurate exe invoke

89493ec

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Oct 22, 2021

View reviewed changes

MichaelRoyceCarroll added 4 commits October 26, 2021 14:55

README.md ospray updates... and some root GSG file staging

ce47d72

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

staging ospray for better heirarchy for CI

4678d2b

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

CMakeLists updates for better CI

db0b27d

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

CMakeLists.txt update for variable consistency

2ead7ea

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Oct 26, 2021

View reviewed changes

Update sample.json

c8ed8b2

praveenkk123 approved these changes Oct 27, 2021

View reviewed changes

praveenkk123 requested a review from pmpeter1 October 28, 2021 23:12

sample.json fixes similar to embree...: remove env, fix pathing

bc1b6a0

praveenkk123 approved these changes Oct 29, 2021

View reviewed changes

Health fixes for cmakelists

b952cc9

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Nov 1, 2021

View reviewed changes

pmpeter1 approved these changes Nov 1, 2021

View reviewed changes

Fix MacOS: Update for rkcommon support lib CMakeLists search path

e8dd20f

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Nov 1, 2021

View reviewed changes

Hopefully better pathing for macos oneapi rk runtime libs (CI only fix)

c0eba32

praveenkk123 approved these changes Nov 1, 2021

View reviewed changes

praveenkk123 merged commit c11a355 into oneapi-src:development Nov 4, 2021

Conversation

MichaelRoyceCarroll commented Oct 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Adding a New Sample(s)

Description

Checklist

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

JoeOster commented Oct 19, 2021

Uh oh!

MichaelRoyceCarroll commented Oct 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll commented Oct 29, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll commented Nov 1, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll commented Nov 1, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MichaelRoyceCarroll commented Oct 18, 2021 •

edited

Loading

MichaelRoyceCarroll commented Oct 21, 2021 •

edited

Loading