Skip to content

New FPGA reference design: ANR#701

Merged
mdbtucker merged 2 commits into
oneapi-src:developmentfrom
tyoungsc:fpga_anr
Oct 14, 2021
Merged

New FPGA reference design: ANR#701
mdbtucker merged 2 commits into
oneapi-src:developmentfrom
tyoungsc:fpga_anr

Conversation

@tyoungsc
Copy link
Copy Markdown
Contributor

@tyoungsc tyoungsc commented Oct 12, 2021 •
edited by mdbtucker
Loading

Description

This is a new FPGA reference design for Adaptive Noise Reduction (ANR).

Checklist

Administrative

  • Review sample design with the appropriate Domain Expert:
  • If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager: @JoeOster

Code Development

Review

  • Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
  • Review readme with Tom Lenth(@tomlenth) and/or Joe Oster(@JoeOster)

pmpeter1
pmpeter1 requested changes Oct 13, 2021
View reviewed changes
Copy link
Copy Markdown

@pmpeter1 pmpeter1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good and consistent with style guidelines. A few cases were highlighted which are inconsistent with the rest of the sample and guidelines.

Comment thread DirectProgramming/DPC++FPGA/ReferenceDesigns/anr/src/anr.hpp Outdated
Comment thread DirectProgramming/DPC++FPGA/ReferenceDesigns/anr/src/anr.hpp Outdated
Comment thread DirectProgramming/DPC++FPGA/ReferenceDesigns/anr/src/anr.hpp Outdated
Comment thread DirectProgramming/DPC++FPGA/ReferenceDesigns/anr/src/qfp.hpp Outdated
Comment thread DirectProgramming/DPC++FPGA/ReferenceDesigns/anr/src/qfp_exp_lut.hpp Outdated
Comment thread DirectProgramming/DPC++FPGA/ReferenceDesigns/anr/src/qfp_inv_lut.hpp Outdated
Comment thread DirectProgramming/DPC++FPGA/ReferenceDesigns/anr/src/rom_base.hpp Outdated
Comment thread DirectProgramming/DPC++FPGA/ReferenceDesigns/anr/src/rom_base.hpp Outdated
@tyoungsc
Copy link
Copy Markdown
Contributor Author

tyoungsc commented Oct 13, 2021

Thanks for the review @pmpeter1. I updated the files to address all of your reviews!

tomlenth
tomlenth approved these changes Oct 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomlenth tomlenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super thorough. thanks!

@mdbtucker mdbtucker requested a review from pmpeter1 October 13, 2021 21:34
@mdbtucker mdbtucker merged commit 9546a53 into oneapi-src:development Oct 14, 2021
@tyoungsc tyoungsc deleted the fpga_anr branch October 14, 2021 15:53
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
@tyoungsc @praveenkk123
New FPGA reference design: ANR (#701)
98ec256 
* New FPGA reference design: ANR

* Changes to address Peter's review: mostly formatting of constants and
magic numbers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmpeter1 pmpeter1 pmpeter1 approved these changes

@praveenkk123 praveenkk123 Awaiting requested review from praveenkk123

+2 more reviewers

@tomlenth tomlenth tomlenth approved these changes

@mdbtucker mdbtucker mdbtucker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2022.1 New Sample FPGA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tyoungsc @tomlenth @pmpeter1 @samples-ci @mdbtucker @Yury-B