Skip to content

add oneDNN and oneCCL samples#58

Merged
JoeOster merged 11 commits into
oneapi-src:masterfrom
louie-tsai:master
Aug 24, 2020
Merged

add oneDNN and oneCCL samples#58
JoeOster merged 11 commits into
oneapi-src:masterfrom
louie-tsai:master

Conversation

@louie-tsai

Copy link
Copy Markdown
Contributor

Signed-off-by: ltsai1 louie.tsai@intel.com
add oneDNN and oneCCL samples

Signed-off-by: ltsai1 <louie.tsai@intel.com>
anjgola
anjgola previously approved these changes Aug 7, 2020

@anjgola anjgola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering CI.

@anjgola

anjgola commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Failed due to sample.json syntax error. Please follow Instructions to move provided that have the details to validate jsons.

@louie-tsai louie-tsai changed the title add oneDNN and oneCCL samples [WIP] add oneDNN and oneCCL samples Aug 7, 2020
@JoeOster JoeOster requested a review from pmpeter1 August 11, 2020 16:27
anjgola
anjgola previously approved these changes Aug 20, 2020

@sravanikonda sravanikonda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change compiler name from Intel oneAPI DPC++ Compiler to Intel oneAPI DPC++/C++ Compiler

@louie-tsai louie-tsai changed the title [WIP] add oneDNN and oneCCL samples add oneDNN and oneCCL samples Aug 20, 2020
samples-ci
samples-ci previously approved these changes Aug 21, 2020

@samples-ci samples-ci left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering CI. Will wait for @sravanikonda 's approval before merging.

anjgola
anjgola previously approved these changes Aug 21, 2020

@anjgola anjgola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triggering CI with my correct account. Will wait @sravanikonda 's approval before merging.

@louie-tsai louie-tsai dismissed stale reviews from anjgola and samples-ci via d664fb5 August 21, 2020 16:28
@louie-tsai

Copy link
Copy Markdown
Contributor Author

@sravanikonda
fixed it according to your input.

anjgola
anjgola previously approved these changes Aug 22, 2020

@anjgola anjgola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering CI

mkitez
mkitez previously approved these changes Aug 24, 2020

@mkitez mkitez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to run CI.
@louie-tsai please review failure details for the simple_model application. It looks like the resulting binary is not found.

"cmake .. -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=dpcpp",
"make",
"mpirun -n 2 ./out/sycl/sycl_allreduce_cpp_test cpu",
"mpirun -n 2 ./out/sycl/sycl_allreduce_cpp_test gpu"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test should be split into 2 configurations, one for CPU the other one for GPU. Same for all other samples.

@JoeOster

Copy link
Copy Markdown
Contributor

@pmpeter1 - can you please approve if appropriate

@pmpeter1 pmpeter1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to follow a consistent coding style.

@JoeOster JoeOster merged commit e5ec85a into oneapi-src:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants