Skip to content

Fortran do conc#1895

Merged
jimmytwei merged 3 commits into
oneapi-src:developmentfrom
hagabb:fortran-do-conc
Sep 18, 2023
Merged

Fortran do conc#1895
jimmytwei merged 3 commits into
oneapi-src:developmentfrom
hagabb:fortran-do-conc

Conversation

@hagabb
Copy link
Copy Markdown
Contributor

@hagabb hagabb commented Sep 15, 2023

Adding a New Sample(s)

Description

This is the Fortran edge detection sample that was approved by the oneAPI Code Samples WG earlier this year. It implements a simple edge detection algorithm using ordinary for-loops and do concurrent loops, then offloads the computing to a GPU using OpenMP.

This sample is more thoroughly described in a recent article on IDZ: https://www.intel.com/content/www/us/en/developer/articles/technical/using-fortran-do-current-for-accelerator-offload.html.

Checklist

Administrative

  • Review sample design with the appropriate Domain Expert: Paul Petersen
  • If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager

Code Development

Security and Legal

  • OSPDT Approval (see Project Manager for assistance)
  • Compile using the following compiler flags and fix any warnings, the flags are: "/Wall -Wformat-security -Werror=format-security"
  • Bandit Scans (Python only)
  • Virus scan

Review

  • Review DPC++ code with Paul Petersen. (GitHub User: pmpeter1)
  • Review readme with Tom Lenth(@tomlenth) and/or Project Manager
  • Tested using Dev Cloud when applicable

Signed-off-by: u172874 <u172874@s001-n161.aidevcloud>
Signed-off-by: hagabb <henry.a.gabb@intel.com>
## Key Implementation Details
[Using Fortran DO CONCURRENT for Accelerator Offload](https://www.intel.com/content/www/us/en/developer/articles/technical/using-fortran-do-current-for-accelerator-offload.html) provides more detailed descriptions of each example code, and discusses the relative merits of each approach.

## License
Copy link
Copy Markdown
Contributor

@jimmytwei jimmytwei Sep 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hagabb Can you move the License section to the end?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the License section to the end of the README.

>
>For more information on environment variables, see Use the setvars Script for [Linux or macOS](https://www.intel.com/content/www/us/en/develop/documentation/oneapi-programming-guide/top/oneapi-development-environment-setup/use-the-setvars-script-with-linux-or-macos.html).

### Running Samples on the DevCloud
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hagabb Can we remove this section (the one that references DevCloud)? We'll have the correct verbiage for IDC at a later date.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the section about the IDC.

Signed-off-by: hagabb <henry.a.gabb@intel.com>
@jimmytwei jimmytwei merged commit 240a890 into oneapi-src:development Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants