fix: Use map[string]interface{} for AppUser.Profile and ApplicationGroupAssignment.Profile#448
Closed
erezrokah wants to merge 1 commit into
Closed
fix: Use map[string]interface{} for AppUser.Profile and ApplicationGroupAssignment.Profile#448erezrokah wants to merge 1 commit into
map[string]interface{} for AppUser.Profile and ApplicationGroupAssignment.Profile#448erezrokah wants to merge 1 commit into
Conversation
…ionGroupAssignment.Profile`
kodiakhq Bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Apr 5, 2024
#### Summary Fixes #17348 by switching to a version of the SDK with the fix from okta/okta-sdk-golang#448 as it seems v4 of the SDK broke some things. Once the PR is merged (and possible additional fixes are done) we can revert back to the official version
|
This PR has been marked stale because there has been no activity within the last 28 days. To keep this PR active, remove the |
Contributor
Author
|
Not stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ##447
So what I did is remove the extra empty
additionalPropertiesfrom the specs and re-ranmake v4-generate. Not sure if there's a better way to do it.The same problem exists in other fields as well (for example
ApplicationGroupAssignment.Embedded) so it might be necessary do go over alladditionalPropertiesin the specs and do the same, but wanted to get some feedback on the fix firstType of PR
Test Information
Go Version:
go version go1.22.1 darwin/arm64Os Version:
OpenAPI Spec Version:
23.4.0 Darwin Kernel Version 23.4.0Signoff
make fmton my code