With GraalVM native, some code will box null into 0 and introduce defects#490
Open
ygyg70 wants to merge 3 commits intoobjectify:masterfrom
Open
With GraalVM native, some code will box null into 0 and introduce defects#490ygyg70 wants to merge 3 commits intoobjectify:masterfrom
ygyg70 wants to merge 3 commits intoobjectify:masterfrom
Conversation
Contributor
|
I have very mixed feelings about this. It basically means slower performance for non-graal users (ie the vast majority of folks) because of a bug in graal. Hmmmm. |
Author
|
Is the difference in performance measurable/significant? |
Contributor
|
I have no idea. The JDK authors must have thought it was significant, otherwise they wouldn't have added MethodHandle in Java7. |
Author
|
One typically choose a layer like Objectify when performance/scale is less important than code readability/maintenance. |
Contributor
|
If I believed a significant portion of Objectify's userbase was using Graal, it would be compelling :-/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to support GraalVM native for my project, came across this issue:
oracle/graal#5672
The change in this pull request (going back to original code flow) seems to solve the issue.
Is there anything wrong with using the old code?