Modify Key class constructor to protected.#269
Open
eincs wants to merge 1 commit intoobjectify:masterfrom
Open
Modify Key class constructor to protected.#269eincs wants to merge 1 commit intoobjectify:masterfrom
eincs wants to merge 1 commit intoobjectify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently creating annotation processor project for Objectify.
With this project, many convenient class source codes for Objectify will automatically generated by annotation processor.
One of generated class will be key class for specific entity.
To to this, modifier of constructors of
Keyclass should be modified to at least protected.Let me give example about key class for specific entity:
Will generate specific key class like:
I think this kind of specific key class makes easier to use Objectify library.
There are several benefits such as...
So, please accept this pull-request!