use method handles to set and get on Fields for performance#10
Open
aleemstreak wants to merge 1 commit intoobjectify:masterfrom
Open
use method handles to set and get on Fields for performance#10aleemstreak wants to merge 1 commit intoobjectify:masterfrom
aleemstreak wants to merge 1 commit intoobjectify:masterfrom
Conversation
|
A couple of years too late, but perhaps it's because the GAE SDK on GAE's servers prevents you from skipping security checks. Are you seeing an improvement when running locally? Perhaps stepping through would reveal what actually happens. Anyway, Java 8 is coming to GAE so possibly a performance increase according to http://stackoverflow.com/questions/19557829/faster-alternatives-to-javas-reflection (not holding my breath) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a rough draft of some code that uses MethodHandles to do the setting and getting. Unfortunately, its not much faster yet. I believe using invokeExact will yield better performance but haven't gotten it to work yet.
Any thoughts or ideas?