ServiceApplicationClient: Add extra_jwt_headers#865
Open
lukaslihotzki-f wants to merge 1 commit intooauthlib:masterfrom
Open
ServiceApplicationClient: Add extra_jwt_headers#865lukaslihotzki-f wants to merge 1 commit intooauthlib:masterfrom
lukaslihotzki-f wants to merge 1 commit intooauthlib:masterfrom
Conversation
auvipy
requested changes
Sep 14, 2023
Member
auvipy
left a comment
There was a problem hiding this comment.
can you add some unit tests for this? it is needed
a69d95d to
d5c93e4
Compare
Author
|
All checks have passed. @auvipy, can you merge it? |
auvipy
requested changes
Sep 20, 2023
| audience=None, | ||
| expires_at=None, | ||
| issued_at=None, | ||
| extra_jwt_headers=None, |
Member
There was a problem hiding this comment.
is it needed for any specific specification or for a particular API/use case only?
Author
There was a problem hiding this comment.
Standard header parameters are defined in RFC 7515. In this document, "kid" is defined, but also other parameters that may be meaningfully used here.
Member
|
lets wait for review from another maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to use the Zitadel token endpoint that needs an extra
"kid"header with ServiceApplicationClient.I named the parameter
extra_jwt_headers(not justextra_headers) to disambiguate it from HTTP headers.