Rename MetadataEndpoint._grant_types -> _grant_types_supported#808
Open
bennr01 wants to merge 2 commits intooauthlib:masterfrom
Open
Rename MetadataEndpoint._grant_types -> _grant_types_supported#808bennr01 wants to merge 2 commits intooauthlib:masterfrom
bennr01 wants to merge 2 commits intooauthlib:masterfrom
Conversation
thedrow
requested changes
Mar 17, 2022
Collaborator
thedrow
left a comment
There was a problem hiding this comment.
Can we write a test to ensure the bug doesn't regress?
Author
|
@thedrow I've added a regression test for the issue. The new test passes with the fix but fails without it. I wasn't exactly sure where to implement it, but as the changes were solely within the code of the |
Author
|
Hi, are there any problems with the changes in this pull request? While one of the test build fails, this is only caused by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this PR renames the
_grant_typesattribute of theMetadataEndpointto_grant_types_supported.Initially introduced in 6bd865b, the
_grant_typesattribute (typelist) collides with the_grant_typesattribute (typedict) of theTokenEndpointwhen inheriting from both classes.This caused a problem: If I want to create an
Server-like combined endpoint inheriting from both theServerandMetadataEndpointclasses and pass a reference to an instance of this class to the constructor of theMetadataEndpoint, initializing theMetadataEndpointwill fail due to it settingself._grant_typesto a list but expecting each of the endpoint working on (which, in my case, includes the metadata endpoint itself) to be of typedict.For example, the following code would fail:
A possible solution is renaming one of the
_grant_typesattributes. This PR does this.