Merged
Conversation
Contributor
Rmarken5
commented
Mar 7, 2023
- issue958
- String manipulation
- Adjust logic to provide external refs
deepmap-marcinr
pushed a commit
that referenced
this pull request
Mar 14, 2023
This reverts commit b42721b. This is one of two related commits that are causing a crash.
Contributor
|
I had to revert this because the codegen was crashing. |
Contributor
Author
Would you mind providing the json that codegen is running against that's causing the crash so I can take another look? |
Contributor
|
Oh, it was the issue 959 unit test, when you run (go generate ./...) at the top of the module, or just in that issue directory. It's crashing in resolving external references because the SchemaRef for something is nil. I've not had a chance to debug further.
It's easy to repro, just revery my revert and try to regenerate. It's probably some conflict with an earlier commit from someone.
…-- Marcin
________________________________________
From: Ryan Marken ***@***.***>
Sent: Sunday, March 19, 2023 4:16 PM
To: deepmap/oapi-codegen
Cc: Marcin Romaszewicz; State change
Subject: Re: [deepmap/oapi-codegen] fix959 (PR #992)
I had to revert this because the codegen was crashing.
Would you mind providing the json that codegen is running against that's causing the crash so I can take another look?
—
Reply to this email directly, view it on GitHub<#992 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALKC5DEPCYSK6VBQCNLBQETW46HVVANCNFSM6AAAAAAVS3VIPI>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
* issue958 * String manipulation * Adjust logic to provide external refs --------- Co-authored-by: Alex Mammay <alexmammay@gmail.com> Co-authored-by: Marcin Romaszewicz <47459980+deepmap-marcinr@users.noreply.github.com>
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
This reverts commit 944312e. This is one of two related commits that are causing a crash.
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
* issue958 * String manipulation * Adjust logic to provide external refs --------- Co-authored-by: Alex Mammay <alexmammay@gmail.com> Co-authored-by: Marcin Romaszewicz <47459980+deepmap-marcinr@users.noreply.github.com>
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
This reverts commit b42721b. This is one of two related commits that are causing a crash.
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
* issue958 * String manipulation * Adjust logic to provide external refs --------- Co-authored-by: Alex Mammay <alexmammay@gmail.com> Co-authored-by: Marcin Romaszewicz <47459980+deepmap-marcinr@users.noreply.github.com>
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
This reverts commit b42721b. This is one of two related commits that are causing a crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.