OneOf: Implicit mapping#932
Merged
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom Mar 14, 2023
Antonboom:feat/oneof-implicit-mapping
Merged
OneOf: Implicit mapping#932deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom Antonboom:feat/oneof-implicit-mapping
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom
Antonboom:feat/oneof-implicit-mapping
Conversation
|
+1 |
kbakdev
approved these changes
Jan 25, 2023
Warboss-rus
suggested changes
Jan 27, 2023
Contributor
Author
|
Could it be merged, guys? @Warboss-rus |
Contributor
|
This looks like a very good change, and doesn't appear to break any generated code, but changes to oneOf/anyOf are terrifying to me since they are so riddled with special cases. |
Contributor
Author
|
@deepmap-marcinr when do you plan to make the new tag? :) |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #712
From https://swagger.io/specification/#discriminator-object.
In scenarios where the value of the discriminator field does not match the schema name or implicit mapping is not possible, an optional mapping definition MAY be used:
Here the discriminator value of dog will map to the schema #/components/schemas/Dog, rather than the default (implicit) value of Dog. If the discriminator value does not match an implicit or explicit mapping, no schema can be determined and validation SHOULD fail. Mapping keys MUST be string values, but tooling MAY convert response values to strings for comparison.