Skip to content

Fix/handle initial digit of http header #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Sep 1, 2022
Merged

Fix/handle initial digit of http header #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
509d4a7
test: internal/test/issues/issue-head-digit-of-httpheader
masu-mi Aug 29, 2022
be7eed9
fix: escape head digit from Request Header name
masu-mi Aug 29, 2022
aa2b243
chore: add issue.gen.go(initial-digit-of-http-header)
masu-mi Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/test/issues/issue-head-digit-of-httpheader/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
package: head_digit_of_httpheader
generate:
strict-server: true
output: issue.gen.go
output-options:
skip-prune: true
3 changes: 3 additions & 0 deletions internal/test/issues/issue-head-digit-of-httpheader/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package head_digit_of_httpheader

//go:generate go run github.com/deepmap/oapi-codegen/cmd/oapi-codegen --config=config.yaml spec.yaml
27 changes: 27 additions & 0 deletions internal/test/issues/issue-head-digit-of-httpheader/issue.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions internal/test/issues/issue-head-digit-of-httpheader/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
openapi: 3.0.2
info:
version: "0.0.1"
paths:
/foo:
get:
responses:
200:
$ref: "#/components/responses/200"
components:
responses:
"200":
headers:
"000-foo":
schema:
type: string
2 changes: 1 addition & 1 deletion pkg/codegen/operations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ func GenerateResponseDefinitions(operationID string, responses openapi3.Response
if err != nil {
return nil, fmt.Errorf("error generating response header definition: %w", err)
}
headerDefinition := ResponseHeaderDefinition{Name: headerName, GoName: ToCamelCase(headerName), Schema: contentSchema}
headerDefinition := ResponseHeaderDefinition{Name: headerName, GoName: SchemaNameToTypeName(headerName), Schema: contentSchema}
responseHeaderDefinitions = append(responseHeaderDefinitions, headerDefinition)
}

Expand Down