Validate OpenAPI spec before performing codegen#713
Draft
jamietanna wants to merge 2 commits into
Draft
Conversation
Although oapi-codegen#544 couldn't have been caught by this, we may be able to flag to users of cases where their OpenAPI is incorrect.
Member
Author
|
Let's make it opt-in? |
Member
|
I added something similar recently: The PR above adds validation for catching codegen errors early and printing nice error messages, versus failing with compile errors later. Given that we have 3.1 support now, you might want to revisit this (but the same argument now holds for 3.2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although #544 couldn't have been caught by this, we may be able to flag
to users of cases where their OpenAPI is incorrect.
This is a draft because until
#373 is resolved, this may break
valid OpenAPI 3.1 specs.