Embed spec v2#327
Merged
3 commits merged intoApr 3, 2021
Merged
Conversation
03b5e86 to
f6c2aa3
Compare
ghost
suggested changes
Apr 2, 2021
| require ( | ||
| github.com/cyberdelia/templates v0.0.0-20141128023046-ca7fffd4298c | ||
| github.com/getkin/kin-openapi v0.47.0 | ||
| github.com/getkin/kin-openapi v0.49.0 |
There was a problem hiding this comment.
Could you rebase and use v0.53.0? The version you're using still forces Go 1.16 because kin-openapi has //embed directives.
Contributor
Author
|
@deepmap-marcinr done |
Closed
Contributor
|
It's really great! Thanks! |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
* implemented openapi specification loading in runtime with external reference resolution * go generate ./... * test "GetSwagger" function using the example with external references
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
* implemented openapi specification loading in runtime with external reference resolution * go generate ./... * test "GetSwagger" function using the example with external references
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the same feature as #320 except for the part that the old PR was based on the new feature in go 1.16 - embed directives, whereas this PR is based on the old -fashion way of embedding content of the spec file in the golang variable as the base64 encoded zipped value.
Due to this change all builds and tests are passed.
Feel free to review the code and request changes or additional explanation.