fix(deps): update module github.com/getkin/kin-openapi to v0.143.0 (go.mod)#2491
Merged
mromaszewicz merged 3 commits intoJul 21, 2026
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Greptile SummaryThis PR updates the kin-openapi dependency and adjusts path ordering for resolved refs.
Confidence Score: 4/5This is close, but the route ordering fix should be adjusted before merging.
pkg/codegen/operations.go
|
| Filename | Overview |
|---|---|
| pkg/codegen/operations.go | Adds handling for external path-item origin metadata during operation ordering. |
| go.mod | Updates the root module to kin-openapi v0.143.0. |
| examples/go.mod | Updates the examples module to kin-openapi v0.143.0. |
| internal/test/go.mod | Updates the internal test module to kin-openapi v0.143.0. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
pkg/codegen/operations.go:1340
**Mixed order sentinel**
When a spec mixes inline paths with external path-item refs, this returns `0` only for the external paths while inline paths keep positive source-line values. The registration sort then places every external path before every inline path, rather than falling back to the stable alphabetical order described here. For overlapping routes, that can still change which generated handler matches first after the dependency update.
Reviews (2): Last reviewed commit: "Fix path ordering" | Re-trigger Greptile
kin-openapi v0.143.0 removed StringMap and introduced attachOriginToResolved, which re-attaches Origins to $ref-resolved path items using the *external* file's origin tree. pathItemSourceLine was therefore returning line numbers from the external file rather than the base spec, producing a different (and non-reproducible across external file layouts) handler registration order. Detect external $ref path items (Ref != "" and not an internal "#/..." ref) and return 0, restoring the stable SortedMapKeys alphabetical fallback that matched pre-v0.143.0 behaviour. Closes: N/A
mromaszewicz
approved these changes
Jul 21, 2026
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
mromaszewicz
enabled auto-merge (squash)
July 21, 2026 23:54
| // pre-v0.143.0 behaviour. | ||
| if pathItem.Ref != "" && !strings.HasPrefix(pathItem.Ref, "#") { | ||
| return 0 | ||
| } |
Contributor
There was a problem hiding this comment.
When a spec mixes inline paths with external path-item refs, this returns 0 only for the external paths while inline paths keep positive source-line values. The registration sort then places every external path before every inline path, rather than falling back to the stable alphabetical order described here. For overlapping routes, that can still change which generated handler matches first after the dependency update.
Knowledge Base Used: Codegen Pipeline
Prompt To Fix With AI
This is a comment left during a code review.
Path: pkg/codegen/operations.go
Line: 1340
Comment:
**Mixed order sentinel**
When a spec mixes inline paths with external path-item refs, this returns `0` only for the external paths while inline paths keep positive source-line values. The registration sort then places every external path before every inline path, rather than falling back to the stable alphabetical order described here. For overlapping routes, that can still change which generated handler matches first after the dependency update.
**Knowledge Base Used:** [Codegen Pipeline](https://app.greptile.com/oapi-codegen/-/custom-context/knowledge-base/oapi-codegen/oapi-codegen/-/docs/codegen-pipeline.md)
How can I resolve this? If you propose a fix, please make it concise.
mromaszewicz
deleted the
renovate/go.mod/github.com-getkin-kin-openapi-0.x
branch
July 21, 2026 23:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.142.0→v0.143.0Release Notes
getkin/kin-openapi (github.com/getkin/kin-openapi)
v0.143.0Compare Source
What's Changed
New Contributors
Full Changelog: getkin/kin-openapi@v0.142.0...v0.143.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.