Skip to content

Stringify non-string text/plain responses in strict servers #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mromaszewicz merged 1 commit into from
Jul 13, 2026
Merged

Stringify non-string text/plain responses in strict servers #2464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/test/bodies/content_types/text_and_json/text_and_json.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions internal/test/bodies/content_types/text_non_string/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# yaml-language-server: $schema=../../../../../configuration-schema.json
# From issue-1897
package: textnonstring
output: text_non_string.gen.go
generate:
std-http-server: true
strict-server: true
models: true
output-options:
skip-prune: true
12 changes: 12 additions & 0 deletions internal/test/bodies/content_types/text_non_string/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Package textnonstring verifies strict-server codegen for text/plain
// responses whose schema is a non-string primitive (integer, boolean).
// The generated Visit* method must compile and write the value's decimal /
// literal text form. Before the fix, the generated code did
// []byte(response) on a non-string-underlying type, which either failed to
// compile (integer, boolean) or, on the fiber/iris path, string(response)
// silently produced a single rune instead of the number.
//
// From issue-1897.
package textnonstring

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.yaml spec.yaml
10 changes: 10 additions & 0 deletions internal/test/bodies/content_types/text_non_string/fiber/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# yaml-language-server: $schema=../../../../../../configuration-schema.json
# From issue-1897 — fiber (ctx.WriteString) backend coverage
package: textnonstringfiber
output: fiber.gen.go
generate:
fiber-server: true
strict-server: true
models: true
output-options:
skip-prune: true
3 changes: 3 additions & 0 deletions internal/test/bodies/content_types/text_non_string/fiber/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package textnonstringfiber

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.yaml ../spec.yaml
159 changes: 159 additions & 0 deletions internal/test/bodies/content_types/text_non_string/fiber/fiber.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions internal/test/bodies/content_types/text_non_string/fiber/fiber_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package textnonstringfiber

import (
"context"
"testing"

"github.com/gofiber/fiber/v2"
"github.com/gofiber/fiber/v2/middleware/adaptor"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/oapi-codegen/testutil"
)

type server struct{}

func (server) GetPing(_ context.Context, _ GetPingRequestObject) (GetPingResponseObject, error) {
return GetPing201TextResponse(201), nil
}

// TestFiberIntegerTextResponse is the fiber-path (ctx.WriteString) regression
// test for issue-1897: an integer text/plain response must serialize as the
// decimal "201", not the single Unicode code-point that string(response)
// previously produced.
func TestFiberIntegerTextResponse(t *testing.T) {
app := fiber.New()
RegisterHandlers(app, NewStrictHandler(server{}, nil))

rr := testutil.NewRequest().Get("/ping").GoWithHTTPHandler(t, adaptor.FiberApp(app)).Recorder
require.Equal(t, 201, rr.Code)
assert.Equal(t, "text/plain", rr.Header().Get("Content-Type"))
assert.Equal(t, "201", rr.Body.String())
}
10 changes: 10 additions & 0 deletions internal/test/bodies/content_types/text_non_string/iris/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# yaml-language-server: $schema=../../../../../../configuration-schema.json
# From issue-1897 — iris (ctx.WriteString) backend coverage
package: textnonstringiris
output: iris.gen.go
generate:
iris-server: true
strict-server: true
models: true
output-options:
skip-prune: true
3 changes: 3 additions & 0 deletions internal/test/bodies/content_types/text_non_string/iris/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package textnonstringiris

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.yaml ../spec.yaml
Loading