Add regression test for enum values containing backslashes#2454
Merged
Conversation
Closes: #2180 The reported miscompilation — a string enum value like N\A emitted verbatim into a double-quoted Go literal — was already fixed by #2433, which routes string enum constants through strconv.Quote. That change shipped without an end-to-end test for this scenario, so pin it with a test generating from the issue's schema and asserting the escaped constant and formattable output. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR adds a regression test for the backslash-in-enum-value miscompilation fixed in #2433, confirming that
Confidence Score: 4/5Safe to merge — the test correctly exercises the fix and cannot break anything in production code. The only change is an additive test that passes today. The sole concern is organizational: the test lives in codegen_test.go instead of the internal/test/schemas/enums leaf, which means no committed golden file is produced and the connection to the project's feature-category test tree is lost. No files require special attention beyond the test placement question in pkg/codegen/codegen_test.go.
|
| Filename | Overview |
|---|---|
| pkg/codegen/codegen_test.go | Adds TestEnumValueEscaping, which correctly verifies that a backslash-containing enum value is emitted as a properly escaped Go literal and that the output is go/format-clean. Functionally sound, but placed in codegen_test.go instead of the canonical internal/test/schemas/enums leaf where it would also produce a committed golden file. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
pkg/codegen/codegen_test.go:584-626
**Test belongs in `internal/test/schemas/enums`, not `codegen_test.go`**
Per the project's test placement rules, enum-escaping scenarios belong in `internal/test/schemas/enums`. The existing leaf already tests illegal identifier generation from pathological enum string values; a backslash-containing value is the same construct with one more variant. The fix is straightforward: add `"N\\A"` to the `Bar` enum in `internal/test/schemas/enums/spec.yaml` (that spec has a path using `Bar`, so `SkipPrune` is not needed), add an assertion in `enums_test.go`, and regenerate `enums.gen.go`. Landing the change in the generated golden file gives a committed proof that `strconv.Quote` is in the output and gives CI a diff-check that will catch any future regression at the template level.
Reviews (1): Last reviewed commit: "Add regression test for enum values cont..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2180
The reported miscompilation — a string enum value like N\A emitted verbatim into a double-quoted Go literal — was already fixed by #2433, which routes string enum constants through strconv.Quote. That change shipped without an end-to-end test for this scenario, so pin it with a test generating from the issue's schema and asserting the escaped constant and formattable output.