Update echo V5 petstore example#2442
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Greptile SummaryThis PR removes the locally-inlined echo-v5 OpenAPI validation middleware (which existed as a workaround until a published package was available) and replaces it with the now-published
Confidence Score: 5/5Safe to merge — the change removes a temporary workaround and replaces it with the published package it was always meant to defer to, with no logic changes at the call site. The change is a straightforward dependency substitution: the locally-inlined middleware is deleted and the now-published equivalent is imported instead. The exported function name (OapiRequestValidator) and call signature are identical, so no downstream code is affected. Indirect dependency bumps are the natural result of go mod tidy after adding the new direct dependency. No files require special attention.
|
| Filename | Overview |
|---|---|
| examples/petstore-expanded/echo-v5/middleware/middleware.go | Deleted: the 226-line locally-inlined echo-v5 middleware (written as a temporary workaround until a published package existed) is removed entirely, replaced by the now-published oapi-codegen/echo-v5-middleware package. |
| examples/petstore-expanded/echo-v5/server/setup.go | Import swapped from the deleted local middleware package to github.com/oapi-codegen/echo-v5-middleware; the call site (mw.OapiRequestValidator) is unchanged and the exported symbol name matches. |
| examples/go.mod | Adds github.com/oapi-codegen/echo-v5-middleware v0.1.0 as a direct dependency (correctly placed in the direct block), bumps labstack/echo/v5 from v5.1.0 to v5.2.1, and updates several indirect dependencies pulled in transitively. |
| examples/go.sum | Checksum file updated to match go.mod changes; no anomalies. |
Reviews (2): Last reviewed commit: "Update echo V5 petstore example" | Re-trigger Greptile
Now that we have echo V5 middleware, use it, rather than recreating it locally.
f05db39 to
962422c
Compare
|
The socket security warning is a false positive. I'm trying to find how to squelch that in the future in their settings. |
|
@SocketSecurity ignore golang/golang.org/x/tools@v0.47.0 |
Now that we have echo V5 middleware, use it, rather than recreating it locally.