Skip to content

Don't emit enum constants for array-typed schemas #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mromaszewicz merged 1 commit into from
Jun 21, 2026
Merged

Don't emit enum constants for array-typed schemas #2424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/codegen/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,7 +970,16 @@ func GenerateGoSchema(sref *openapi3.SchemaRef, path []string) (Schema, error) {
}

return outSchema, nil
} else if len(schema.Enum) > 0 || (globalState.is31 && schema.Const != nil) {
} else if (len(schema.Enum) > 0 || (globalState.is31 && schema.Const != nil)) && !t.Is("array") {
// An `enum` (or 3.1 `const`) is only meaningful on a scalar schema:
// it constrains a single value, which we render as a typed constant.
// A schema that combines `type: array` with an `enum` is malformed --
// the enum members are scalars, not arrays, so no array value could
// satisfy it (seen in the wild as a copy of the item enum onto the
// array; see issue #2176). Emitting constants there yields
// `const X SliceType = ...`, which is not a valid Go constant type.
// Fall through to normal array handling so the schema generates as a
// plain `[]ItemType`; the item schema carries the real enum.
err := oapiSchemaToGoType(schema, path, &outSchema)
// Enums need to be typed, so that the values aren't interchangeable,
// so no matter what schema conversion thinks, we need to define a
Expand Down