fix: correctly generate consistent media type for type aliases#2411
Merged
Conversation
Without this change, we'll generate i.e.
ApplicationvndApiJSON422 *CreateItem422ApplicationvndApiJSONResponseBody
Instead of
ApplicationvndApiJSON422 *CreateItem422ApplicationVndAPIPlusJSONResponseBody
As the type doesn't exist, this introduces a compilation error.
We can instead make sure we're consistently generating the media type
name.
Co-authored-by: Claude Sonnet 4.6 <jamie.tanna+claude-code@rootly.com>
1 task
Contributor
Greptile SummaryThis PR fixes response body type naming for vendored JSON media types. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| pkg/codegen/operations.go | Aligns vendored JSON response body tag generation with the existing strict response body naming path. |
| internal/test/issue-vnd-json/schema.gen.go | Generated fixture now points the vendored JSON response field at the matching generated response body type. |
| internal/test/issue-vnd-json/spec.yaml | Adds a focused OpenAPI repro for application/vnd.api+json responses with an inline union body. |
Reviews (1): Last reviewed commit: "fix: correctly generate consistent media..." | Re-trigger Greptile
Member
Author
|
A follow-up may be needed here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, we'll generate i.e.
Instead of
As the type doesn't exist, this introduces a compilation error.
We can instead make sure we're consistently generating the media type
name.
Co-authored-by: Claude Sonnet 4.6 jamie.tanna+claude-code@rootly.com