fix/deprecated#2405
Draft
jamietanna wants to merge 3 commits into
Draft
Conversation
f95c51f to
d471034
Compare
As part of future changes, we'll be improving how `oapi-codegen` generates deprecation notices through godoc. Before we do this, we can introduce a more in-depth test case for the different areas that can be marked as deprecated, so we can validate the functionality. With help from As a starting point from **??**, we can then extend this to: - Cover at least an HTTP client and server - Add Strict Server functionality - Deprecate a parameter - Generate a deprecation on `components/response` Co-authored-by: Claude Sonnet 4.6 <jamie.tanna+claude-code@rootly.com>
This adds a new **??**, dep-reason fix: emit deprecation notice on deprecated type definitions Types defined in components/schemas (and elsewhere) with deprecated:true now get a // Deprecated: comment as the final paragraph of their doc comment, which godoc and IDEs recognise as a deprecation warning. Adds DocComment() and DeprecationComment() to TypeDefinition, and updates typedef.tmpl to call DocComment() instead of inlining the description logic. Co-authored-by: Claude Sonnet 4.6 <jamie.tanna+claude-code@rootly.com>
d471034 to
c390cb3
Compare
Member
Author
|
@greptileai review |
Contributor
Greptile SummaryThis PR adds generated Go deprecation comments from OpenAPI metadata. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Reviews (3): Last reviewed commit: "fixup! fix: deprecate **??**" | Re-trigger Greptile |
Member
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.