Echo V5 now uses the generic test framework#2382
Merged
mromaszewicz merged 1 commit intoMay 19, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR moves Echo v5 parameter coverage into the shared parameter round-trip tests. It changes:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| internal/test/parameters/param_roundtrip_test.go | Adds Echo v5 to the shared parameter round-trip test setup. |
| internal/test/parameters/echov5/server.go | Updates the Echo v5 test server to implement the generated interface from the new gen package. |
| internal/test/parameters/echov5/gen/server.gen.go | Commits the generated Echo v5 server fixture in the new package location. |
| internal/test/parameters/echov5/gen/types.gen.go | Commits the generated Echo v5 model and parameter types in the new package location. |
Reviews (2): Last reviewed commit: "Echo V5 now uses the generic test framew..." | Re-trigger Greptile
When I updated to Go 1.25 and un-moduled the echo-v5 code, I left behind the special-cased test for echo-v5 which existed due to module boundaries. Since those modules don't exist anymore, we can remove the special casing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mromaszewicz
force-pushed
the
chore/cleanup-echov5-test
branch
from
May 19, 2026 16:17
c6dbeac to
c5c06db
Compare
Member
Author
lwc
pushed a commit
to lwc/oapi-codegen
that referenced
this pull request
Jun 23, 2026
When I updated to Go 1.25 and un-moduled the echo-v5 code, I left behind the special-cased test for echo-v5 which existed due to module boundaries. Since those modules don't exist anymore, we can remove the special casing. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I updated to Go 1.25 and un-moduled the echo-v5 code, I left behind the special-cased test for echo-v5 which existed due to module boundaries. Since those modules don't exist anymore, we can remove the special casing.