Skip to content

chore(renovate): correctly run make tidy#2374

Merged
jamietanna merged 3 commits into
mainfrom
chore/renovate-
May 17, 2026
Merged

chore(renovate): correctly run make tidy#2374
jamietanna merged 3 commits into
mainfrom
chore/renovate-

Conversation

@jamietanna

Copy link
Copy Markdown
Member
  • chore(renovate): correct path for go.sum
  • chore(renovate): add explicit parent path
  • chore(renovate): add missing description

@jamietanna
jamietanna requested a review from a team as a code owner May 17, 2026 13:18
@greptile-apps

greptile-apps Bot commented May 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates Renovate's Go module post-upgrade rule. The main changes are:

  • Adds root go.mod and go.sum to the matching patterns.
  • Corrects the nested go.sum path pattern.
  • Adds a description for the make tidy post-upgrade task.

Confidence Score: 4/5

This is close, but the Renovate file filter should be fixed before merging.

  • Root Go module updates now trigger make tidy.

  • The allowed post-upgrade files still exclude root go.mod and go.sum.

  • Renovate can produce incomplete root module dependency branches.

  • renovate.json

Important Files Changed

Filename Overview
renovate.json Updates the Renovate package rule that runs make tidy after Go module updates.

Comments Outside Diff (1)

  1. renovate.json, line 67-70 (link)

    P1 Include root tidy files

    The rule now matches root go.mod and go.sum, so a root Go dependency update can run make tidy. But the post-upgrade fileFilters still only allow nested module files. When make tidy changes the root go.mod or go.sum, Renovate can leave those tidied files out of the branch, producing an incomplete dependency update.

Reviews (1): Last reviewed commit: "chore(renovate): add missing description" | Re-trigger Greptile

@jamietanna
jamietanna merged commit fd9959a into main May 17, 2026
28 checks passed
@jamietanna
jamietanna deleted the chore/renovate- branch May 17, 2026 13:22
@jamietanna jamietanna added the chore Any maintenance tasks that are regular, not as important to call out in the changelog label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Any maintenance tasks that are regular, not as important to call out in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant